%unit:ignore broken since 8.0?
Monday, 30 March 2015 · 5 messages · last reply 7 Apr 2015
MG
Marc van Grootel30 Mar 2015 22:14 #
Hi,
Could it be that %unit:ignore("message") is broken since 8.0.
Whenever I use a message in the annotation my tests fail with this error message:
<error line="149" column="21" type="bxerr:BASX0006">
<info>%unit:ignore: 1 argument supplied.</info>
</error>When ("mesage") is removed the test is ok.
Documentation let's me believe %unit:ignore("message") is still supported.
--Marc
LK
Lukas Kircher31 Mar 2015 08:16 #
Hi Marc,
sorry for the inconvenience - there have indeed been some changes to the unit module in the recent past, that are not yet covered by the documentation.
I assume unit:ignore is one of them (w/o checking the sources). Christian is out of town at the moment, so it might take a week before we get back to you.
Cheers,
Lukas
Quoted text · Marc van Grootel · 20 lines
On Mon, Mar 30, 2015 at 10:14 PM, Marc van Grootel < marc.van.grootel at gmail.com> wrote: > Hi, > > Could it be that %unit:ignore("message") is broken since 8.0. > > Whenever I use a message in the annotation my tests fail with this > error message: > > <error line="149" column="21" type="bxerr:BASX0006"> > <info>%unit:ignore: 1 argument supplied.</info> > </error> > > When ("mesage") is removed the test is ok. > > Documentation let's me believe %unit:ignore("message") is still supported. > > > --Marc >
MG
Marc van Grootel31 Mar 2015 10:37 #
Thanks.
Looking at the code in
basex-core/src/main/java/org/basex/query/ann/Annotation.java
_UNIT_IGNORE("ignore()", arg(), UNIT_URI),
I do indeed see that no arg is allowed. But I wonder what the thinking behind it is. Being able to put a message there to indicate why the test was ignored is quite handy to have.
--Marc
Quoted text · Lukas Kircher · 35 lines
On Tue, Mar 31, 2015 at 8:16 AM, Lukas Kircher <lukaskircher1 at gmail.com> wrote: > Hi Marc, > > sorry for the inconvenience - there have indeed been some changes to the > unit module in the recent past, that are not yet covered by the > documentation. > I assume unit:ignore is one of them (w/o checking the sources). Christian is > out of town at the moment, so it might take a week before we get back to > you. > > Cheers, > Lukas > > On Mon, Mar 30, 2015 at 10:14 PM, Marc van Grootel > <marc.van.grootel at gmail.com> wrote: >> >> Hi, >> >> Could it be that %unit:ignore("message") is broken since 8.0. >> >> Whenever I use a message in the annotation my tests fail with this >> error message: >> >> <error line="149" column="21" type="bxerr:BASX0006"> >> <info>%unit:ignore: 1 argument supplied.</info> >> </error> >> >> When ("mesage") is removed the test is ok. >> >> Documentation let's me believe %unit:ignore("message") is still supported. >> >> >> --Marc > >
--
--Marc
LK
Lukas Kircher31 Mar 2015 10:57 #
Quoted text · Marc van Grootel · 4 lines
> > behind it is. Being able to put a message there to indicate why the > test was ignored is quite handy to have. >
I agree ...
CG
Hi Marc,
Quoted text · Marc van Grootel · 2 lines
> I do indeed see that no arg is allowed. But I wonder what the thinking > behind it is.
The thinking here was simply non-existent; the bug was introduced by the revision of our annotation handling: in earlier versions, all annotatoins were dynamically parsed. Now, you already get feedback at parse time if some of your annotations are invalid.
The bug should now be fixed, please check out the latest snapshot [1].
Thanks for reporting,
Christian
[1] http://files.basex.org/releases/latest
Quoted text · Marc van Grootel · 54 lines
On Tue, Mar 31, 2015 at 10:37 AM, Marc van Grootel <marc.van.grootel at gmail.com> wrote: > Thanks. > Looking at the code in > basex-core/src/main/java/org/basex/query/ann/Annotation.java > > _UNIT_IGNORE("ignore()", arg(), UNIT_URI), > > I do indeed see that no arg is allowed. But I wonder what the thinking > behind it is. Being able to put a message there to indicate why the > test was ignored is quite handy to have. > > --Marc > > On Tue, Mar 31, 2015 at 8:16 AM, Lukas Kircher <lukaskircher1 at gmail.com> wrote: >> Hi Marc, >> >> sorry for the inconvenience - there have indeed been some changes to the >> unit module in the recent past, that are not yet covered by the >> documentation. >> I assume unit:ignore is one of them (w/o checking the sources). Christian is >> out of town at the moment, so it might take a week before we get back to >> you. >> >> Cheers, >> Lukas >> >> On Mon, Mar 30, 2015 at 10:14 PM, Marc van Grootel >> <marc.van.grootel at gmail.com> wrote: >>> >>> Hi, >>> >>> Could it be that %unit:ignore("message") is broken since 8.0. >>> >>> Whenever I use a message in the annotation my tests fail with this >>> error message: >>> >>> <error line="149" column="21" type="bxerr:BASX0006"> >>> <info>%unit:ignore: 1 argument supplied.</info> >>> </error> >>> >>> When ("mesage") is removed the test is ok. >>> >>> Documentation let's me believe %unit:ignore("message") is still supported. >>> >>> >>> --Marc >> >> > > > > -- > --Marc
Written for BaseX 8.1. BaseX may have changed since: please check the current documentation.
⚡Generated with XQuery