Minor PR/fix suggestion

Wednesday, 19 September 2018 · 3 messages · last reply 24 Sep 2018
BD
Bridger Dyson-Smith19 Sep 2018 23:23 #
Hi Christian, et al, I'm guessing that you're all busy with working towards a 9.1 release (yay!), but if you have time would you consider an incredibly minor PR? I recently noticed that the BaseX GUI supports completion and it's great. I found a small typo in the completions: sliding=for tumbling window should be sliding=for sliding window It's super-duper simple, but I have a branch with the typo fixed[1]. In any event, thanks! Looking forward to the next release. Best, Bridger [1] https://github.com/CanOfBees/basex/tree/fix-completions-typo
CG
Christian Grün24 Sep 2018 18:34 #
Done! A new snapshot will be available in a few minutes.
Quoted text · Bridger Dyson-Smith · 19 lines
On Wed, Sep 19, 2018 at 9:23 PM Bridger Dyson-Smith <bdysonsmith at gmail.com> wrote: > > Hi Christian, et al, > > I'm guessing that you're all busy with working towards a 9.1 release (yay!), but if you have time would you consider an incredibly minor PR? > > I recently noticed that the BaseX GUI supports completion and it's great. I found a small typo in the completions: > `sliding=for tumbling window` should be > `sliding=for sliding window` > > It's super-duper simple, but I have a branch with the typo fixed[1]. > > In any event, thanks! > Looking forward to the next release. > Best, > Bridger > [1] https://github.com/CanOfBees/basex/tree/fix-completions-typo >
BD
Bridger Dyson-Smith24 Sep 2018 20:38 #
Thanks!
Quoted text · Christian Grün · 28 lines
On Mon, Sep 24, 2018 at 12:34 PM Christian Grün <christian.gruen at gmail.com> wrote: > Done! A new snapshot will be available in a few minutes. > > > > On Wed, Sep 19, 2018 at 9:23 PM Bridger Dyson-Smith > <bdysonsmith at gmail.com> wrote: > > > > Hi Christian, et al, > > > > I'm guessing that you're all busy with working towards a 9.1 release > (yay!), but if you have time would you consider an incredibly minor PR? > > > > I recently noticed that the BaseX GUI supports completion and it's > great. I found a small typo in the completions: > > `sliding=for tumbling window` should be > > `sliding=for sliding window` > > > > It's super-duper simple, but I have a branch with the typo fixed[1]. > > > > In any event, thanks! > > Looking forward to the next release. > > Best, > > Bridger > > [1] https://github.com/CanOfBees/basex/tree/fix-completions-typo > > >

⚡Generated with XQuery